Document and complement XInclude failures as warnings on translations #196
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR better document how XInclude failures are treated on translations. It only cares for
<xi:include>
without<xi:failback>
, so it leaves open<xi:failback>
usage for other situations.In fact, I tested this on all languages with
doc-en
stripped of<xi:failback>
.As an recommendation, I suggest mass removing all mentions of
<xi:failback>
ondoc-en
, down to XML comments, after 8.4 doc changes calms down, and possibly further creating an github action/trigger that recuses usage of<xi:failback>
, linking this trigger to mentionXInclude failures are soft errors on translations
. onconfigure.php
. The reason being that failed XInclude leaves different artifacts in the presence and absence of<xi:failback>
. Caring for both is very confusing.