Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to PER CS coding style instead of PEAR #167

Merged
merged 1 commit into from
Oct 23, 2024

Conversation

jimwins
Copy link
Member

@jimwins jimwins commented Oct 22, 2024

Doesn't seem to be any pushback on updating this, so let's do it

@jimwins
Copy link
Member Author

jimwins commented Oct 22, 2024

Discussion here: https://news-web.php.net/php.doc/969388442

@Crell
Copy link

Crell commented Oct 23, 2024

Not sure what the deal is with the failing builds, but the text looks good to me.

Copy link
Member

@cmb69 cmb69 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@cmb69
Copy link
Member

cmb69 commented Oct 23, 2024

@Crell, build failures are because some translations are not up to date (likely latest changes to MongoDB).

Copy link
Member

@Girgias Girgias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for pushing this. :)

@jimwins jimwins merged commit 7dbeaf2 into php:master Oct 23, 2024
5 of 12 checks passed
@jimwins jimwins deleted the change-coding-style-reference branch October 23, 2024 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants