Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add acronyms #160

Merged
merged 2 commits into from
Oct 5, 2024
Merged

Add acronyms #160

merged 2 commits into from
Oct 5, 2024

Conversation

haszi
Copy link
Contributor

@haszi haszi commented Oct 5, 2024

Add acronyms and corresponding entities for frequently used abbreviations. This is mostly based on abbreviations found in the cURL chapter of the docs.

Copy link
Member

@cmb69 cmb69 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for woking on this!

@@ -282,6 +360,12 @@
<simpara>Privacy-Enhanced Mail</simpara>
</listitem>
</varlistentry>
<varlistentry>
<term>Phar</term>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if "Phar" is considered an acronym, but it's okay for me to add it.

entities/global.ent Outdated Show resolved Hide resolved
<!ENTITY book.applied.cryptography 'Applied Cryptography by Schneier (ISBN 0-471-11709-9)'>
<!ENTITY book.programming.classics "Programming Classics: Implementing the World's Best Algorithms by Oliver (ISBN 0-131-00413-1)">

<!ENTITY email.harald 'harald.radi@nme.at'>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure this is a good idea?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was already part of the global entities file, I just accidentally duplicated all but the acronyms part of it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if they would even reply :')

entities/global.ent Outdated Show resolved Hide resolved
entities/global.ent Outdated Show resolved Hide resolved
Copy link
Member

@Girgias Girgias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@Girgias Girgias merged commit 43b9fe2 into php:master Oct 5, 2024
9 of 12 checks passed
@haszi haszi deleted the Add-acronyms branch October 5, 2024 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants