Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove XForms from the manual (part of php/doc-en#3579) #136

Merged
merged 1 commit into from
Jul 27, 2024

Conversation

jimwins
Copy link
Member

@jimwins jimwins commented Jul 23, 2024

The XForms content will also need to be removed from each of the doc-$LANG repos.

jimwins added a commit to jimwins/doc-en that referenced this pull request Jul 23, 2024
Requires php/doc-base#136 to remove entities and references
@jimwins
Copy link
Member Author

jimwins commented Jul 24, 2024

Thinking about it further, the correct order to do everything would be to remove all of the references to XForms from all of the translations (references in translated chapters/tutorial.xml and all translated features/xforms.xml) and the reference to features/xforms from chapters/tutorial.xml in php/doc-en, then remove it from manual.xml.in here in php/doc-base, and then finally remove features/xforms.xml from php/doc-en. The entities can finally be removed here. That should leave everything buildable after each PR. (Unless the build fails when there are unused entities?)

@Girgias
Copy link
Member

Girgias commented Jul 26, 2024

Unused entities are fine.

You will need to do the doc-en changes first, as the translators need to update the EN-Revision tag, I have pushed major changes by using a revcheck skip but I try to limit my usage of those.

@jimwins
Copy link
Member Author

jimwins commented Jul 27, 2024

Going to go ahead and merge this now that it's just three languages (it, pl, tr) that haven't pushed the submitted PR to remove this. They can clean up after the fact.

@jimwins jimwins merged commit 6875931 into php:master Jul 27, 2024
8 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants