Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix git refs not showing on Windows #116

Merged
merged 2 commits into from
Jan 31, 2024

Conversation

haszi
Copy link
Contributor

@haszi haszi commented Jan 31, 2024

Fixes the issue with git ref printing on Windows showing the following error messages on each run:

The system cannot find the path specified.
The system cannot find the path specified.
The filename, directory name, or volume label syntax is incorrect.
doc-base:
The system cannot find the path specified.
The system cannot find the path specified.
The filename, directory name, or volume label syntax is incorrect.
en:

Additionally, this PR adds a switch to enable Windows to switch (ie. cd) between drives and not just directories on the same drive.

haszi added 2 commits January 31, 2024 10:21
Fix git refs now showing on some Windows shells by replacing ; between commands
with && and removing them at the end of commands.
Add a switch that enables Windows to switch between drives.
Copy link
Member

@Girgias Girgias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Girgias Girgias merged commit 6f04778 into php:master Jan 31, 2024
10 checks passed
@haszi haszi deleted the Fix-git-refs-not-showing-on-Windows branch January 31, 2024 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants