pktmem: Fix warning #84
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
JIRA: RTOS-555
agkaminski
force-pushed
the
agkaminski/rtos-555
branch
from
5d1b27d to
e085733
Compare
badochov
reviewed
Aug 10, 2023
| #define PKT_BUF_IDX 11 // log2(PAGE_SIZE) - ceil(log2(PKT_BUF_CNT)) | ||
| #define PKT_BUF_SIZE (2048 - CACHE_LINE_SIZE) | ||
| #define PKT_BUF_CNT (size_t)((_PAGE_SIZE - CACHE_LINE_SIZE) / PKT_BUF_SIZE) | ||
| #define PKT_BUF_IDX 11 /* log2(_PAGE_SIZE) - ceil(log2(PKT_BUF_CNT)) */ |
There was a problem hiding this comment.
We don't know what is _PAGE_SIZE as its in the arch.h so making this value a constant is misleading . IMHO either this comment should change or LOG2 macro that does LOG2 in proprocessing stage should be added(probably overkill)
There was a problem hiding this comment.
We don't know it's value and use definit oo on from arch.h, because it's target dependent. We need a value provided by arch for mmap/munap to work properly
There was a problem hiding this comment.
yes, but the the reason for it being exactly 11 is that we assumed page_size == 4096 at least acoording to the comment
There was a problem hiding this comment.
Ok, now I understand what you mean
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: RTOS-555
Description
Fixes phoenix-rtos/phoenix-rtos-project#141
Motivation and Context
Types of changes
How Has This Been Tested?
Checklist:
Special treatment