Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: migrate from remix v2 + react-router v6 to react-router v7 #105

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

chore: migrate from remix v2 + react-router v6 to react-router v7 #105

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a98b970
chore: migrate from remix v2 + react-router v6 to react-router v7
JoshuaKGoldberg Jul 23, 2024
f422cd5
Experimental release with fixes
brophdawg11 Jul 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
"dependencies": {
"@axe-core/playwright": "^4.9.1",
"@playwright/test": "^1.45.1",
"@react-router/node": "0.0.0-nightly-90ebbf91d-20240718",
"@react-router/node": "0.0.0-experimental-49eef6a01",
"clsx": "^2.1.1",
"eslint-plugin-react": "^7.34.3",
"eslint-plugin-react-hooks": "^4.6.2",
Expand All @@ -41,11 +41,11 @@
"playwright": "^1.45.1",
"react": "^18.3.1",
"react-dom": "^18.3.1",
"react-router": "0.0.0-nightly-90ebbf91d-20240718"
"react-router": "0.0.0-experimental-49eef6a01"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an experimental release from remix-run/react-router#11833 that fixes the issues we found on the stream:

  • __manifest is now pre-rendered
  • Trailing slashes are removed from single fetch data calls so no more invalid /about/.data calls
  • Hydration loops should be resolved since we detect via matches and not a direct URL comparison

},
"devDependencies": {
"@react-router/dev": "0.0.0-nightly-90ebbf91d-20240718",
"@react-router/serve": "0.0.0-nightly-90ebbf91d-20240718",
"@react-router/dev": "0.0.0-experimental-49eef6a01",
"@react-router/serve": "0.0.0-experimental-49eef6a01",
"@remix-run/eslint-config": "^2.10.2",
"@types/react": "^18.3.3",
"@types/react-dom": "^18.3.0",
Expand Down
Loading
Loading