chore: migrate from remix v2 + react-router v6 to react-router v7 #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoshuaKGoldberg
commented
Jul 23, 2024
| @@ -1,7 +1,3 @@ | |||
| // We deploy to static pages, so this must be a client-only component. | |||
| // https://github.com/philly-js-club/philly-js-club-website/issues/61 | |||
| "use client"; | |||
There was a problem hiding this comment.
TODO for Josh: move to a separate PR
brophdawg11
reviewed
Jul 23, 2024
| @@ -41,11 +41,11 @@ | |||
| "playwright": "^1.45.1", | |||
| "react": "^18.3.1", | |||
| "react-dom": "^18.3.1", | |||
| "react-router": "0.0.0-nightly-90ebbf91d-20240718" | |||
| "react-router": "0.0.0-experimental-49eef6a01" | |||
There was a problem hiding this comment.
This is an experimental release from remix-run/react-router#11833 that fixes the issues we found on the stream:
__manifestis now pre-rendered- Trailing slashes are removed from single fetch data calls so no more invalid
/about/.datacalls - Hydration loops should be resolved since we detect via matches and not a direct URL comparison
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
status: accepting prsOverview
Result of a pairing on stream with @brophdawg11: https://www.youtube.com/watch?v=ikRmJPg5GWU Uses react-router@7's
prerenderto more natively render static contents.💖
Co-authored-by: @brophdawg11