chore: remove unnecessary unstable_defineLoader #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brophdawg11
commented
Jul 22, 2024
| @@ -46,7 +45,7 @@ export default function Index() { | |||
| </h2> | |||
| {events.map((event, index) => ( | |||
| <EventDetails | |||
| date={new Date(event.date)} | |||
| date={event.date} | |||
There was a problem hiding this comment.
With Single Fetch these are de-serialized as Date instances so we don't need this anymore
JoshuaKGoldberg
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In preparation for the livestream tomorrow - removing the
unstable_defineLoaderAPI that shipped originally with Single Fetch but is going to be removed in an upcoming Remix release. That way we don't show anyone any dead APIs that's are on the way out. We still get effectively the same + correct type-inference fromexport function loaderin our simplistic use cases