Merge branch 'master' into fix-tests

src/Hermes-Extensions/HEDuplicationModeStrategy.class.st

@@ -19,27 +19,27 @@ HEDuplicationModeStrategy class >> forOption: keyword [
 
 { #category : #'validating existence' }
 HEDuplicationModeStrategy >> doExistingClass: aClass hermesClass: aHEClass installer: installer [
-	self subclassResponsibility 
+	self subclassResponsibility
 ]
 
 { #category : #'validating existence' }
 HEDuplicationModeStrategy >> doExistingTrait: aTrait hermesTrait: aHETrait installer: installer [
-	self subclassResponsibility 
+	self subclassResponsibility
 ]
 
 { #category : #'validating existence' }
 HEDuplicationModeStrategy >> doShouldBuildMethod: aHEMethod in: installer installer: aClass original: aMethod [
-	self subclassResponsibility 
+	self subclassResponsibility
 ]
 
 { #category : #'validating existence' }
 HEDuplicationModeStrategy >> existingClass: aHEClass on: installer [
 	^ installer environment
 		at: aHEClass className
-		ifPresent: [ :aClass | 
-			self 
-				doExistingClass: aClass 
-				hermesClass: aHEClass 
+		ifPresent: [ :aClass |
+			self
+				doExistingClass: aClass
+				hermesClass: aHEClass
 				installer: installer  ]
 		ifAbsent: [ nil ]
 ]
@@ -48,10 +48,10 @@ HEDuplicationModeStrategy >> existingClass: aHEClass on: installer [
 HEDuplicationModeStrategy >> existingTrait: aHETrait on: installer [
 	^ installer environment
 		at: aHETrait traitName
-		ifPresent: [ :aTrait | 
-			self 
-				doExistingTrait: aTrait 
-				hermesTrait: aHETrait 
+		ifPresent: [ :aTrait |
+			self
+				doExistingTrait: aTrait
+				hermesTrait: aHETrait
 				installer: installer ]
 		ifAbsent: [ nil ]
 ]
@@ -60,13 +60,13 @@ HEDuplicationModeStrategy >> existingTrait: aHETrait on: installer [
 HEDuplicationModeStrategy >> shouldBuildMethod: aHEMethod in: aClass installer: installer [
 	^ aClass
 		compiledMethodAt: aHEMethod name
-		ifPresent: [ :m | 
+		ifPresent: [ :m |
 			(m isFromTrait and: [ aClass isTrait not ])
 				ifTrue: [ ^ true ].
-			self 
-				doShouldBuildMethod: aHEMethod 
-				in: installer 
-				installer: aClass 
+			self
+				doShouldBuildMethod: aHEMethod
+				in: installer
+				installer: aClass
 				original: m]
 		ifAbsent: [ true ]
 ]

src/Hermes-Extensions/HEExtendedInstaller.class.st

@@ -26,12 +26,12 @@ HEExtendedInstaller >> duplicationMode: anObject [
 
 { #category : #'validating existence' }
 HEExtendedInstaller >> existingClass: aHEClass [
-	^ duplicationMode existingClass: aHEClass on: self.
+	^ duplicationMode existingClass: aHEClass on: self
 ]
 
 { #category : #'validating existence' }
 HEExtendedInstaller >> existingTrait: aHETrait [
-	^ duplicationMode existingTrait: aHETrait on: self.
+	^ duplicationMode existingTrait: aHETrait on: self
 ]
 
 { #category : #accessing }
@@ -43,14 +43,14 @@ HEExtendedInstaller >> failOnUndeclared: anObject [
 HEExtendedInstaller >> forOptions: aCommandLine [
 	failOnUndeclared := (aCommandLine hasOption: 'no-fail-on-undeclared') not.
 
-	duplicationMode := HEDuplicationModeStrategy forOption: (aCommandLine optionAt: 'on-duplication' ifAbsent: [ 'fail' ]).
+	duplicationMode := HEDuplicationModeStrategy forOption: (aCommandLine optionAt: 'on-duplication' ifAbsent: [ 'fail' ])
 ]
 
 { #category : #initialization }
 HEExtendedInstaller >> initialize [
 	super initialize.
 	failOnUndeclared := true.
-	duplicationMode := HEFailOnDuplication new.
+	duplicationMode := HEFailOnDuplication new
 ]
 
 { #category : #'reporting undeclared' }
@@ -65,5 +65,5 @@ HEExtendedInstaller >> reportNewUndeclareds: newUndeclareds [
 
 { #category : #'validating existence' }
 HEExtendedInstaller >> shouldBuildMethod: aHEMethod in: aClass [
-	^ duplicationMode shouldBuildMethod: aHEMethod in: aClass installer: self.
+	^ duplicationMode shouldBuildMethod: aHEMethod in: aClass installer: self
 ]

src/Hermes/HEAdditionalMethodState.class.st

@@ -23,7 +23,7 @@ Class {
 
 { #category : 'accessing' }
 HEAdditionalMethodState class >> tag [
-	^ 1.
+	^ 1
 ]
 
 { #category : 'converting' }
@@ -42,8 +42,7 @@ HEAdditionalMethodState >> asLiteralIn: env [
 HEAdditionalMethodState >> doReadFrom: aReader [
 	method := HEExportedLiteral readFrom: aReader.
 	selector := HEExportedLiteral readFrom: aReader.
-	value := HEExportedLiteral readFrom: aReader.
-
+	value := HEExportedLiteral readFrom: aReader
 ]
 
 { #category : 'accessing' }

src/Hermes/HEArray.class.st

@@ -21,7 +21,7 @@ Class {
 
 { #category : 'accessing' }
 HEArray class >> tag [
-	^ 2.
+	^ 2
 ]
 
 { #category : 'converting' }
@@ -32,12 +32,12 @@ HEArray >> asLiteralIn: env [
 
 { #category : 'reading' }
 HEArray >> doReadFrom: aReader [
-	| size | 
+	| size |
 	"The size of the array is stored as a 32bits integer. Before any of the elements"
 	size := aReader readInt32.
 	value := Array new:size.
-	
-	1 to:size do:[:idx | value at:idx put: (HEExportedLiteral readFrom: aReader)].
+
+	1 to:size do:[:idx | value at:idx put: (HEExportedLiteral readFrom: aReader)]
 ]
 
 { #category : 'accessing' }

src/Hermes/HEAssociation.class.st

@@ -28,12 +28,11 @@ HEAssociation >> asLiteralIn: env [
 { #category : 'reading' }
 HEAssociation >> doReadFrom: aReader [
 	key := HEExportedLiteral readFrom: aReader.
-	value := HEExportedLiteral readFrom: aReader.
-
+	value := HEExportedLiteral readFrom: aReader
 ]
 
 { #category : 'accessing' }
 HEAssociation >> value: anAssociation [
 	value := anAssociation value asExportedLiteral.
-	key := anAssociation key asExportedLiteral.
+	key := anAssociation key asExportedLiteral
 ]

src/Hermes/HEBinaryReader.class.st

@@ -26,7 +26,7 @@ Class {
 
 { #category : 'initialization' }
 HEBinaryReader >> close [
-	self stream close.
+	self stream close
 ]
 
 { #category : 'sizes' }
@@ -42,7 +42,7 @@ HEBinaryReader >> readByte [
 { #category : 'reading' }
 HEBinaryReader >> readByteArray [
 	| byteArray size |
-	size := self readInt32. 
+	size := self readInt32.
 	byteArray := stream next: size.
 	^ byteArray
 ]
@@ -54,7 +54,7 @@ HEBinaryReader >> readByteString [
 
 { #category : 'reading' }
 HEBinaryReader >> readByteSymbol [
-	^ self readByteString asSymbol 
+	^ self readByteString asSymbol
 ]
 
 { #category : 'reading' }

src/Hermes/HEByteArray.class.st

@@ -23,5 +23,5 @@ HEByteArray >> asLiteralIn: env [
 
 { #category : 'reading' }
 HEByteArray >> doReadFrom: aReader [
-	value := aReader readByteArray.
+	value := aReader readByteArray
 ]

src/Hermes/HEByteString.class.st

@@ -13,7 +13,7 @@ Class {
 
 { #category : 'accessing' }
 HEByteString class >> tag [
-	^ 4.
+	^ 4
 ]
 
 { #category : 'converting' }
@@ -24,10 +24,10 @@ HEByteString >> asLiteralIn: env [
 { #category : 'reading' }
 HEByteString >> doConvertValue: aValue [
 	"My subclasses are able to do something else to convert the readed value"
-	^ aValue.
+	^ aValue
 ]
 
 { #category : 'reading' }
 HEByteString >> doReadFrom: aReader [
-	value := self doConvertValue:(aReader readByteString).
+	value := self doConvertValue:(aReader readByteString)
 ]

src/Hermes/HECharacter.class.st

@@ -14,7 +14,7 @@ Class {
 
 { #category : 'accessing' }
 HECharacter class >> tag [
-	^ 5.
+	^ 5
 ]
 
 { #category : 'converting' }
@@ -24,5 +24,5 @@ HECharacter >> asLiteralIn: env [
 
 { #category : 'accessing' }
 HECharacter >> value: aValue [
-	value := aValue asString.
+	value := aValue asString
 ]

src/Hermes/HEClass.class.st

@@ -99,7 +99,7 @@ HEClass >> layoutClass: anObject [
 
 { #category : 'accessing' }
 HEClass >> name [
-	
+
 	^ self className
 ]
 

src/Hermes/HEClassTrait.class.st

@@ -25,5 +25,5 @@ HEClassTrait >> asLiteralIn: env [
 
 { #category : 'accessing' }
 HEClassTrait >> value: aClassTrait [
-	value := aClassTrait instanceSide name.
+	value := aClassTrait instanceSide name
 ]

src/Hermes/HEClassVariable.class.st

@@ -15,16 +15,16 @@ Class {
 
 { #category : 'accessing' }
 HEClassVariable class >> tag [
-	^ 6.
+	^ 6
 ]
 
 { #category : 'converting' }
 HEClassVariable >> asLiteralIn: env [
 	"I ask the binding to the class that is currently being deserialized"
-	^ env newClass bindingOf: value 
+	^ env newClass bindingOf: value
 ]
 
 { #category : 'accessing' }
 HEClassVariable >> value: aClassVariable [
-	value := aClassVariable name.
+	value := aClassVariable name
 ]

src/Hermes/HECompiledBlock.class.st

@@ -24,12 +24,12 @@ HECompiledBlock class >> tag [
 HECompiledBlock >> asLiteralIn: anEnvironment [
 
 	| containingBlockOrMethod newBlock literalSpace previousBlock|
-	
+
 	previousBlock := anEnvironment newBlock.
 	containingBlockOrMethod := previousBlock ifNil: [ anEnvironment newMethod ].
-	
+
 	newBlock := CompiledBlock newMethod: bytecode size header: (self headerFor: anEnvironment).
-	
+
 	anEnvironment newBlock: newBlock.
 
 	literals
@@ -68,7 +68,7 @@ HECompiledBlock >> headerFor: anEnvironment [
 	| encoderClass|
 	"When a method is deserialized its header should be recalculated"
 	encoderClass := anEnvironment classNamed: encoderClassName.
-	
+
 	^ (CompiledMethod headerFlagForEncoder: encoderClass) + (numArgs bitShift: 24) + (numTemps bitShift: 18) + literals size + (hasPrimitive bitShift: 16)
 ]
 

src/Hermes/HEConstantBlock.class.st

@@ -32,7 +32,7 @@ HEConstantBlock >> doReadFrom: aReader [
 
 	numArgs := aReader readUInt32.
 	literal := HEExportedLiteral readFrom: aReader.
-	compiledBlock := HEExportedLiteral readFrom: aReader.
+	compiledBlock := HEExportedLiteral readFrom: aReader
 ]
 
 { #category : 'comparing' }

src/Hermes/HEExportedLiteral.class.st

@@ -60,7 +60,7 @@ HEExportedLiteral >> asLiteralIn: anEnvironment [
 { #category : 'reading' }
 HEExportedLiteral >> doReadFrom: aReader [
 	"Main template method to read the instance from the reader stream"
-	self subclassResponsibility.
+	self subclassResponsibility
 ]
 
 { #category : 'accessing' }

src/Hermes/HEExportedMetaclass.class.st

@@ -25,5 +25,5 @@ HEExportedMetaclass >> asLiteralIn: env [
 
 { #category : 'accessing' }
 HEExportedMetaclass >> value: aMetaclass [
-	value := aMetaclass instanceSide name.
+	value := aMetaclass instanceSide name
 ]

src/Hermes/HEFloat.class.st

@@ -16,12 +16,12 @@ Class {
 
 { #category : 'accessing' }
 HEFloat class >> tag [
-	^ 3.
+	^ 3
 ]
 
 { #category : 'converting' }
 HEFloat >> asLiteralIn: env [
-	^ value.
+	^ value
 ]
 
 { #category : 'reading' }
@@ -30,7 +30,7 @@ HEFloat >> doReadFrom: aReader [
 	originalValue := BoxedFloat64 new.
 	originalValue at:1 put: (aReader readUInt32).
 	originalValue at:2 put: (aReader readUInt32).
-	
+
 	"Force the conversion to SmallFloat64 or BoxedFloat64"
-	value := originalValue - 0.0.
+	value := originalValue - 0.0
 ]

src/Hermes/HEGlobalVariable.class.st

@@ -16,20 +16,20 @@ Class {
 
 { #category : 'accessing' }
 HEGlobalVariable class >> tag [
-	^ 7.
+	^ 7
 ]
 
 { #category : 'converting' }
 HEGlobalVariable >> asLiteralIn: env [
 	| bind |
 	bind := env newClass bindingOf: value.
-	
+
 	bind ifNotNil: [ ^ bind ].
-	
+
 	^UndeclaredVariable registeredWithName: value
 ]
 
 { #category : 'accessing' }
 HEGlobalVariable >> value: aClassVariable [
-	value := aClassVariable name.
+	value := aClassVariable name
 ]

src/Hermes/HEMethod.class.st

@@ -62,7 +62,7 @@ HEMethod >> headerFor: anEnvironment [
 	| encoderClass|
 	"When a method is deserialized its header should be recalculated"
 	encoderClass := anEnvironment classNamed: encoderClassName.
-	
+
 	^ (CompiledMethod headerFlagForEncoder: encoderClass) + (numArgs bitShift: 24) + (numTemps bitShift: 18) + literals size + (hasPrimitive bitShift: 16)
 ]
 
@@ -111,7 +111,7 @@ HEMethod >> readFrom: aReader [
 	name := aReader readByteSymbol.
 	className := aReader readByteSymbol.
 	protocol := aReader readByteSymbol.
-		
+
 	encoderClassName := aReader readByteString.
 	numArgs := aReader readUInt32.
 	numTemps := aReader readUInt32.