-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Might want to add a note about bumping the package version as well (see my comment in [this PR](https://github.com/pharmaverse/admiraltemplate/pull/72#pullrequestreview-1872726088)) #3
Comments
I'll look into this |
@manciniedoardo i was thinking about this and we only actually need to implement this after our first foundational 0.1.0 release, as nobody is really going to install latest github version until then. we don't even need to update NEWS file until then either, as will explain now on slack channel |
Makes sense - I’ve since located the documentation for how to implement this, so if you change your mind I can set this up. Otherwise we can keep as an action item for after first release. |
@manciniedoardo feel free to add any PR for this now as needed, as we're on CRAN. The action does fire already for us though and me and @Fanny-Gautier learned that we should use [skip vbump] in PR title if ever we want to bipass this. |
@manciniedoardo is anything needed updating here or could we close this one out? me and @Fanny-Gautier are looking at wrapping up admiralpeds now ready for the Jan release. tbh we think this package will be relatively stable from here on out as we've not heard much user feedback on anything to change or any new features needed. |
Might want to add a note about bumping the package version as well (see my comment in this PR)
Originally posted by @manciniedoardo in #1 (comment)
The text was updated successfully, but these errors were encountered: