Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: PKNCA imputations do not disconsider observed parameters #182

Open
Gero1999 opened this issue Jan 29, 2025 · 0 comments
Open

Bug: PKNCA imputations do not disconsider observed parameters #182

Gero1999 opened this issue Jan 29, 2025 · 0 comments
Labels
bug Something isn't working

Comments

@Gero1999
Copy link
Collaborator

Description

There are parameters (i.e, cmax, tmax) that should be based merely on observations, and not imputed data. At first we though that this was controlled by PKNCA, but it is not, so it is a bug that eventually will need to be solved by PKNCA. In the meantime, as a temporary measure we will develop a solution for this problem that is external to the package.

Suggested solution
Make a function that only and simply modifies the PKNCAdata$intervals, i.e, remove_impute_for_params(PKNCAdata, params). The function identifies rows/intervals where param = TRUE & !is.na(impute), set in those param = FALSE and create duplicates where param = TRUE, impute = NA

To reproduce

Run NCA on IV bolus data in both conditions: considering t0 and not considering it. You can see that, erroneously, C0 and t0 values change in each run!

Expected behaviour

t0 and c0 should in any case change when imputations are added

@Gero1999 Gero1999 added the bug Something isn't working label Jan 29, 2025
@Gero1999 Gero1999 added this to aNCA Jan 29, 2025
@m-kolomanski m-kolomanski moved this to Backlog in aNCA Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Backlog
Development

No branches or pull requests

1 participant