Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Slope Selector Plots incorrect #165

Open
3 tasks
js3110 opened this issue Jan 20, 2025 · 0 comments · May be fixed by #177
Open
3 tasks

Bug: Slope Selector Plots incorrect #165

js3110 opened this issue Jan 20, 2025 · 0 comments · May be fixed by #177
Assignees
Labels
bug Something isn't working

Comments

@js3110
Copy link
Collaborator

js3110 commented Jan 20, 2025

Description

The slope selector plots do not always match the NCA results, showing the wrong line of best fit or points included in lambda z. This is best noticed when comparing the output of one analyte vs multiple analytes for the same subject profile.

Looks like lamda.z.ix is being calculated incorrectly.
In addition, if user uses the table and selects 1:8 as manual slope, the selection includes 2,3,4,5,6,7 but not 1 and 8. Would be better if it was inclusive of the range the user inputs.

To reproduce

Run for one analyte
Run again for multiple analytes
Notice the plots have changed (should be the same for each one)
Notice that the points included in the plots don't always correspond to the lambda z points included in the NCA results.

Expected behaviour

  • Slope plots should correspond exactly to the NCA results, and be the same no matter how many analytes / pcspec have been selected.

  • Exclusions and inclusions should work fine, for both manual table adding or adding via interactive plots

  • Inclusions should include the IX values the user inputs

@js3110 js3110 added the bug Something isn't working label Jan 20, 2025
@js3110 js3110 added this to aNCA Jan 20, 2025
@js3110 js3110 moved this to Todo in aNCA Jan 21, 2025
@Shaakon35 Shaakon35 assigned Shaakon35 and js3110 and unassigned Shaakon35 Jan 21, 2025
@js3110 js3110 moved this from Todo to In Progress in aNCA Jan 21, 2025
@js3110 js3110 linked a pull request Jan 24, 2025 that will close this issue
9 tasks
@js3110 js3110 linked a pull request Jan 24, 2025 that will close this issue
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: In Progress
Development

Successfully merging a pull request may close this issue.

2 participants