Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Manual slope selection and automatic PKNCA behaviour conflicts #148

Open
Gero1999 opened this issue Jan 2, 2025 · 0 comments
Open
Labels
bug Something isn't working

Comments

@Gero1999
Copy link
Collaborator

Gero1999 commented Jan 2, 2025

Description

We would like that PKNCA's automatic behaviour does not include never automatically tmax for the half life calculation and that it takes 3 points always... This would be:

    # Use the user inputs to determine the NCA settings to apply
    PKNCA::PKNCA.options(
      auc.method = input$method,
      allow.tmax.in.half.life = FALSE,

      # Make sure the standard options do not prohibit results
      min.hl.r.squared = 0.001,
      min.span.ratio = Inf,
      min.hl.points = 3
    )

Note: Other potential additional interests could be as well: using the min.hl.r.adj (still not possible in PKNCA) and the min.span.ratio defined by the users.

However, using this PLNCA.options can also affect the behaviour of the manual configuration done in the slope_selector module. For that reason we would like a solution that makes both fit together

An initial proposed easy-fix would be to only compute these PKNCA.options for "best_slopes" while on "manual_slopes" that are selected by the user perform other more permissive PKNCA.options:

    # Use the user inputs to determine the NCA settings to apply
    PKNCA::PKNCA.options(
      auc.method = input$method,
      allow.tmax.in.half.life = TRUE,

      # Make sure the standard options do not prohibit results
      min.hl.r.squared = 0.001,
      min.span.ratio = Inf,
      min.hl.points = 2
    )

To reproduce

  1. Being in code min.hl.points = 2
    Map data > Submit analyte/dosno > Run NCA > In slope selector try to choose only 2 points for your slope

  2. Being in code allow.tmax.in.half.life = FALSE
    Map data > Submit analyte/dosno > Run NCA > In slope selector try to choose only 2 points for your slope

Expected behaviour

That the user can choose any point in the slope selector while the automatic selection in the app does exclude tmax and chooses always 3 points.

@Gero1999 Gero1999 added the bug Something isn't working label Jan 2, 2025
@js3110 js3110 moved this to Backlog in aNCA Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Backlog
Development

No branches or pull requests

1 participant