Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: Migrate the NCA tab to shiny modules and bslib #144

Open
3 tasks
js3110 opened this issue Dec 16, 2024 · 3 comments
Open
3 tasks

Refactor: Migrate the NCA tab to shiny modules and bslib #144

js3110 opened this issue Dec 16, 2024 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@js3110
Copy link
Collaborator

js3110 commented Dec 16, 2024

Description

Since incorporation of bslib ui layout to data and outputs section, nca section formatting is bad. Needs to be updated so it looks better.

Definition of Done:

  • NCA tab refactored to be contained within shiny modules
  • NCA tabs reformatted to fit bslib
  • All sections correctly formatted in an easy to use and easy to read way.
@js3110 js3110 added the enhancement New feature or request label Dec 16, 2024
@js3110 js3110 moved this to Backlog in aNCA Dec 16, 2024
@m-kolomanski
Copy link
Collaborator

In addition, we should finally modularize this tab. #146 adds some changes to nca.R file, so probably this issue should follow. I think part of the issues with code logic in the above PR stems from the fact that this part of the application still lives free instead of being encapsulated.

@js3110
Copy link
Collaborator Author

js3110 commented Jan 8, 2025

@m-kolomanski completely agree, and I was already thinking of modularising the tab once #109 and #146 are complete. We can do it as part of this issue, or separately within #63 , what do you think?

@m-kolomanski
Copy link
Collaborator

Within this issue, at this point #63 is an "epic" issue, existing to remind of a bigger goal rather than a task on its own right.

I am renaming this issue to reflect the actual wanted changes and we can work within that.

@m-kolomanski m-kolomanski changed the title Bug: NCA Section not adapted to bslib Refactor: Migrate the NCA tab to shiny modules and bslib Jan 8, 2025
@m-kolomanski m-kolomanski self-assigned this Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Todo
Development

No branches or pull requests

2 participants