Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Substantially improve Photon results with map-derived parameters #339

Merged
merged 1 commit into from
Dec 26, 2024

Conversation

shivak
Copy link
Contributor

@shivak shivak commented May 7, 2023

The Photon geocoder returns poor, jarring results unless the center point and zoom of the map are included as query parameters. Now these data are included. They are passed via the context argument, so other geocoders with similar optional parameters may be improved as well.

Repository owner deleted a comment from Simic69 Dec 15, 2024
@Cyrille37
Copy link
Contributor

Hi. Any comment about this PR ? It looks interesting ;-)

The Photon geocoder returns poor results unless the center point and
zoom of the map are included as query parameters.
Copy link
Collaborator

@simon04 simon04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I've reworked this patch for the new promise-based API. Before, the context was meant to be used as this context for the callback. I'll fix the typing error in a follow-up commit.

@simon04 simon04 merged commit 66e361e into perliedman:master Dec 26, 2024
0 of 2 checks passed
simon04 added a commit that referenced this pull request Dec 26, 2024
simon04 added a commit that referenced this pull request Dec 26, 2024
@Cyrille37
Copy link
Contributor

Thanks :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants