Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ornamenting Jingle Bells #310

Merged
merged 15 commits into from
Nov 30, 2023
Merged

Ornamenting Jingle Bells #310

merged 15 commits into from
Nov 30, 2023

Conversation

ology
Copy link
Contributor

@ology ology commented Nov 17, 2023

How about some music this year? :D

=head2 SYNOPSIS

$ perl jingle-bells
$ timidity jingle-bells.mid
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe a quick paragraph on playing MIDI files, with something that works on Windows too.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

Copy link
Contributor Author

@ology ology Nov 25, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have added instruction sections for playing MIDI on different systems in 7443025

@briandfoy briandfoy added WIP 2023 Everything related to the 2023 Advent Calendar labels Nov 25, 2023
@oalders
Copy link
Contributor

oalders commented Nov 25, 2023

Closes #288

Copy link
Contributor

@oalders oalders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

\o/

@oalders oalders merged commit 918004d into perladvent:main Nov 30, 2023
1 check passed
@oalders oalders removed the WIP label Dec 1, 2023
@oalders
Copy link
Contributor

oalders commented Dec 1, 2023

It looks great! https://perladvent.org/2023/2023-12-01.html

Thank you @oalders and @briandfoy! If anything needs to be fixed, we can still do that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2023 Everything related to the 2023 Advent Calendar
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants