PMM-9875 Errors view usage. #1244
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
JiriCtvrtka
force-pushed
the
PMM-9875-errors-view-usage
branch
from
ff8d677 to
9e02f1b
Compare
Codecov Report
@@ Coverage Diff @@
## main #1244 +/- ##
==========================================
- Coverage 44.05% 43.98% -0.07%
==========================================
Files 334 334
Lines 39790 39869 +79
==========================================
+ Hits 17529 17537 +8
- Misses 20737 20808 +71
Partials 1524 1524
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -426,6 +436,56 @@ func (m *PGStatMonitorQAN) getNewBuckets(ctx context.Context, periodLengthSecs u | |||
| return buckets, nil | |||
| } | |||
|
|
|||
| func (m *PGStatMonitorQAN) checkErrorsView(ctx context.Context) error { | |||
There was a problem hiding this comment.
🚫 [golangci-lint] reported by reviewdog 🐶
calculated cyclomatic complexity for function checkErrorsView is 12, max is 10 (cyclop)
JiriCtvrtka
requested review from
BupycHuk,
percona-csalguero and
ShashankSinha252
|
Original PR: percona/pmm-agent#370 |
percona-csalguero
approved these changes
Sep 22, 2022
ShashankSinha252
approved these changes
Sep 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PMM-9875
Original PR: percona/pmm-agent#370
Build: SUBMODULES-2664
Links to other linked pull requests (optional).