-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow Wharton Council officers to manage associated clubs #778
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #778 +/- ##
==========================================
+ Coverage 72.67% 73.22% +0.54%
==========================================
Files 32 32
Lines 7078 7092 +14
==========================================
+ Hits 5144 5193 +49
+ Misses 1934 1899 -35 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking the initiative on this Julian -- pretty cool way to get around the WC permissions stuff. Left a couple comments.
Also, let's maybe add a views test that ensures that WC officers have edit access over a constituent club?
…atest unapproved versions of clubs akin to club members
backend/clubs/permissions.py
Outdated
@@ -163,6 +163,8 @@ def has_object_permission(self, request, view, obj): | |||
# user must be in club or parent club to perform non-view actions | |||
membership = find_membership_helper(request.user, obj) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(old PR that came to mind #241)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the catch, definitely is supported (sync apparently wasn't a cron: f608990 but that's a separate story) ... will repurpose this PR for the minor change to approved club version viewing and adding a test for the find_membership_helper
behavior
…ync (barring adding/deleting badges implied by non-child descendent relationship)
@aviupadhyayula we now sync badges to parent-child relationships on editing badges of a club as discussed: it should ensure consistency as long as 1. badge organizations aren't editable and 2. the badge being edited is a result of a direct parent-child relationship as opposed to an indirect descendant, can you verify if this is true and if so, what kind of workarounds we can implement to support these? |
Enable WC officers to change club settings and provisioned applications for WC clubs, avoiding access issues involving non-WC clubs.