Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent duplicate committees #772

Draft
wants to merge 23 commits into
base: master
Choose a base branch
from

Conversation

aviupadhyayula
Copy link
Member

Clubs sometimes mess up during creating applications, and have multiple committees with the same name.

This PR adds serializer-level checks to prevent duplicate committees tied to the same application. Also adds a DB-level constraint.

The merge_duplicate_committees command retroactively fixes existing applications by merging committees together. This should be run in prod, and then removed from this PR.

Copy link

codecov bot commented Jan 29, 2025

Codecov Report

Attention: Patch coverage is 28.57143% with 40 lines in your changes missing coverage. Please review.

Project coverage is 72.00%. Comparing base (7c8281a) to head (b3d7198).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
.../management/commands/merge_duplicate_committees.py 21.56% 40 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #772      +/-   ##
==========================================
+ Coverage   71.98%   72.00%   +0.02%     
==========================================
  Files          32       33       +1     
  Lines        6963     7019      +56     
==========================================
+ Hits         5012     5054      +42     
- Misses       1951     1965      +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aviupadhyayula aviupadhyayula marked this pull request as draft January 29, 2025 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant