Add back codecov #619
Merged
Add back codecov #619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aviupadhyayula
approved these changes
Feb 20, 2024
There was a problem hiding this comment.
LGTM. Nit: should we consider passing in a value to GITHUB_HEAD_REF?[1] Would be useful to see how coverage would change after a PR.[2]
[1] https://docs.codecov.com/docs/error-reference#missing-head-commit
[2] https://app.codecov.io/github/pennlabs/penn-clubs/commit/917c0c9d93cf9f270f5232ee36ff8db8731a33a2
Discussed offline, think this will be handled automatically |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See title, also moved
coverageto dev dependencies