From ded17afd26496d17172834afd803f9b5e6f51cc4 Mon Sep 17 00:00:00 2001 From: Sritan Motati Date: Tue, 11 Feb 2025 23:32:34 -0500 Subject: [PATCH] Revert "more prettier fixes for non-health" This reverts commit f61a9eb94e5cb2ec3f7299eaafbc3a53e37f79be. --- frontend/components/ClubDetails.tsx | 4 ++-- frontend/components/ClubPage/LiveEventsDialog.tsx | 3 +-- frontend/components/Settings/FairEventsTab.tsx | 2 +- frontend/components/Settings/WhartonApplicationTab.tsx | 2 +- frontend/pages/constitutions.tsx | 2 +- frontend/pages/events/index.tsx | 2 +- 6 files changed, 7 insertions(+), 8 deletions(-) diff --git a/frontend/components/ClubDetails.tsx b/frontend/components/ClubDetails.tsx index 41db5254b..0b2fd12fe 100644 --- a/frontend/components/ClubDetails.tsx +++ b/frontend/components/ClubDetails.tsx @@ -101,9 +101,9 @@ const Details = ({ club }: DetailsProps): ReactElement => { {applicationRequired === ClubApplicationRequired.ApplicationAndInterview ? 'Application & Interview' - : (CLUB_APPLICATIONS.find( + : CLUB_APPLICATIONS.find( ({ value }) => value === applicationRequired, - )?.label ?? 'Unknown')} + )?.label ?? 'Unknown'} )} {isClubFieldShown('accepting_members') && ( diff --git a/frontend/components/ClubPage/LiveEventsDialog.tsx b/frontend/components/ClubPage/LiveEventsDialog.tsx index 450b7a592..c73fad89a 100644 --- a/frontend/components/ClubPage/LiveEventsDialog.tsx +++ b/frontend/components/ClubPage/LiveEventsDialog.tsx @@ -16,8 +16,7 @@ import { FAIR_NAME, MEMBERSHIP_ROLE_NAMES } from '../../utils/branding' export const LiveBanner = styled.div` padding: 20px; border-radius: 5px; - background-image: - radial-gradient( + background-image: radial-gradient( circle at 15% 0, rgba(216, 127, 200, 0.5), rgba(73, 84, 244, 0.4) 36% diff --git a/frontend/components/Settings/FairEventsTab.tsx b/frontend/components/Settings/FairEventsTab.tsx index 7f47b46d2..6192bb9a8 100644 --- a/frontend/components/Settings/FairEventsTab.tsx +++ b/frontend/components/Settings/FairEventsTab.tsx @@ -45,7 +45,7 @@ const FairEventsTab = ({ ) const [selectedFair, setSelectedFair] = useState( fairs != null && !('detail' in fairs) && fairs.length > 0 - ? (initialSelection ?? fairs[0].id) + ? initialSelection ?? fairs[0].id : null, ) const [fairEvents, setFairEvents] = useState< diff --git a/frontend/components/Settings/WhartonApplicationTab.tsx b/frontend/components/Settings/WhartonApplicationTab.tsx index f3972aa1f..45df0b7e2 100644 --- a/frontend/components/Settings/WhartonApplicationTab.tsx +++ b/frontend/components/Settings/WhartonApplicationTab.tsx @@ -65,7 +65,7 @@ const WhartonApplicationTab = ({ const wordCount = application.questions.reduce( (acc, question) => acc + question.question_type === ApplicationQuestionType.FreeResponse - ? (question.word_limit ?? 0) + ? question.word_limit ?? 0 : 0, 0, ) diff --git a/frontend/pages/constitutions.tsx b/frontend/pages/constitutions.tsx index 1b6ec45de..c45cb547c 100644 --- a/frontend/pages/constitutions.tsx +++ b/frontend/pages/constitutions.tsx @@ -102,7 +102,7 @@ const ConstitutionDirectory = ({ clubs }: Props): ReactElement => { {file.name} ) : ( - (file.name ?? 'Hidden') + file.name ?? 'Hidden' ), ), ', ', diff --git a/frontend/pages/events/index.tsx b/frontend/pages/events/index.tsx index 0d92d2101..0da7da704 100644 --- a/frontend/pages/events/index.tsx +++ b/frontend/pages/events/index.tsx @@ -47,7 +47,7 @@ export const getServerSideProps = (async (ctx) => { const clubMap = new Map(clubs.map((club) => [club.code, club])) const eventsWithClubs = events.map((event) => ({ ...event, - club: event.club ? (clubMap.get(event.club) ?? null) : null, + club: event.club ? clubMap.get(event.club) ?? null : null, clubPublic: event.club == null || clubMap.get(event.club) !== undefined, })) return {