Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make vault client attempt reconnect to overlay network if periodic health check fails #580

Open
ebma opened this issue Jan 30, 2025 · 0 comments
Labels
type:bug Something isn't working

Comments

@ebma
Copy link
Member

ebma commented Jan 30, 2025

Context

Currently, the vault client logs periodic health check messages if it continues to receive SCP messages from the overlay node. If the health check fails (ie no SCP message is received within some timeframe), the vault doesn't act on this. This causes other issues as for example the check for the recoverable slot here might always return true even if the slot is long past, just because the last_slot_index doesn't update anymore.

TODO

A simple solution would be to send a shutdown signal and have the vault client restart.

@ebma ebma added the type:bug Something isn't working label Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant