You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Following up to the changes made in #513, we need to modify our pre-commit and pre-push hooks. The problem is that the pre-commit hook will run rustfmt using the stable toolchain (as that's the one defined in the rust-toolchain.toml file) but the check in CI performs the check using a nightly toolchain, see here.
The problem with the pre-push hook is that it's not performing the same checks as we have in the workflow file anymore.
TODO
Either move the rustfmt check to be performed by the stable toolchain in the CI or change the pre-commit hook to use the respective nightly version. We should fix this version to the same version that is used in the CI file though.
Changing the hook to use the nightly toolchain is preferable because some checks are only available on the nightly version
Change the pre-push hook to perform similar clippy checks as the ci workflow. Here, maybe we have to cut corners and reduce it to just one of the two checks. The problem is that the check will take forever as we'd first need to compile with the stable toolchain and then with the nightly version.
The text was updated successfully, but these errors were encountered:
@pendulum-chain/product this only improves our developer experience and doesn't add any new features. It's quite annoying though, so I'd appreciate if someone can work on this soon.
Following up to the changes made in #513, we need to modify our pre-commit and pre-push hooks. The problem is that the pre-commit hook will run
rustfmt
using the stable toolchain (as that's the one defined in therust-toolchain.toml
file) but the check in CI performs the check using a nightly toolchain, see here.The problem with the pre-push hook is that it's not performing the same checks as we have in the workflow file anymore.
TODO
rustfmt
check to be performed by the stable toolchain in the CI or change the pre-commit hook to use the respective nightly version. We should fix this version to the same version that is used in the CI file though.The text was updated successfully, but these errors were encountered: