chore: Bump serde from 1.0.217 to 1.0.218 (#391) #914

Triggered via push February 20, 2025 08:37

kodiakhq[bot]

pushed 44e0f52

main

Status Success

Total duration 2m 36s

Artifacts –

ci.yaml

on: push

Matrix: Build and Test

Annotations

27 warnings

deref which would be done by auto-deref: fatigue/src/main.rs#L99

warning: deref which would be done by auto-deref --> fatigue/src/main.rs:99:47 | 99 | output_formatter.update_result_status(&*rx.borrow()); | ^^^^^^^^^^^^^ help: try: `&rx.borrow()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref = note: `#[warn(clippy::explicit_auto_deref)]` on by default

usage of an `Arc` that is not `Send` and `Sync`: fatigue/src/main.rs#L77

warning: usage of an `Arc` that is not `Send` and `Sync` --> fatigue/src/main.rs:77:28 | 77 | let output_formatter = Arc::new(get_output_formatter()); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = note: `Arc<Box<dyn OutputFormatter>>` is not `Send` and `Sync` as `Box<dyn OutputFormatter>` is neither `Send` nor `Sync` = help: if the `Arc` will not used be across threads replace it with an `Rc` = help: otherwise make `Box<dyn OutputFormatter>` `Send` and `Sync` or consider a wrapper type such as `Mutex` = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#arc_with_non_send_sync = note: `#[warn(clippy::arc_with_non_send_sync)]` on by default

redundant closure: libfatigue/src/context/mod.rs#L158

warning: redundant closure --> libfatigue/src/context/mod.rs:158:18 | 158 | .map(|a| StaticContextTracker::new(a)) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `StaticContextTracker::new` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure = note: `#[warn(clippy::redundant_closure)]` on by default

you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let`: libfatigue/src/context/result.rs#L64

warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` --> libfatigue/src/context/result.rs:64:13 | 64 | / match &action.internal { 65 | | Ok(info) => self.mark_success_action(info, action), 66 | | Err(_) => {} 67 | | } | |_____________^ help: try: `if let Ok(info) = &action.internal { self.mark_success_action(info, action) }` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match

returning the result of a `let` binding from a block: libfatigue/src/context/actions/json.rs#L43

warning: returning the result of a `let` binding from a block --> libfatigue/src/context/actions/json.rs:43:21 | 42 | let res = serde_json::from_str(raw.as_str())?; | ---------------------------------------------- unnecessary `let` binding 43 | res | ^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return = note: `#[warn(clippy::let_and_return)]` on by default help: return the expression directly | 42 ~ 43 ~ serde_json::from_str(raw.as_str())? |

you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let`: libfatigue/src/actions/request.rs#L91

warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` --> libfatigue/src/actions/request.rs:91:9 | 91 | / match &self.props.response_context_key { 92 | | Some(key) => { 93 | | let body = &resp.json::<Value>().await?; 94 | | ctx.items ... | 97 | | None => {} 98 | | }; | |_________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match = note: `#[warn(clippy::single_match)]` on by default help: try | 91 ~ if let Some(key) = &self.props.response_context_key { 92 + let body = &resp.json::<Value>().await?; 93 + ctx.items 94 + .insert(key.clone(), liquid::model::to_value(&body).unwrap()); 95 ~ }; |

useless conversion to the same type: `std::str::Lines<'_>`: libfatigue/src/actions/request.rs#L34

warning: useless conversion to the same type: `std::str::Lines<'_>` --> libfatigue/src/actions/request.rs:34:43 | 34 | let rendered_path_lines: Vec<_> = rendered_path | ___________________________________________^ 35 | | .lines() 36 | | .into_iter() | |________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion = note: `#[warn(clippy::useless_conversion)]` on by default help: consider removing `.into_iter()` | 34 ~ let rendered_path_lines: Vec<_> = rendered_path 35 + .lines() |

Cargo Sort check

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

Cargo Sort check

Cargo Clippy Check

Build and Test (ubuntu-latest, stable)

virtual workspace defaulting to `resolver = "1"` despite one or more workspace members being on edition 2021 which implies `resolver = "2"`

Build and Test (ubuntu-latest, stable)

virtual workspace defaulting to `resolver = "1"` despite one or more workspace members being on edition 2021 which implies `resolver = "2"`

Build and Test (windows-latest, stable)

virtual workspace defaulting to `resolver = "1"` despite one or more workspace members being on edition 2021 which implies `resolver = "2"`

Build and Test (windows-latest, stable)

virtual workspace defaulting to `resolver = "1"` despite one or more workspace members being on edition 2021 which implies `resolver = "2"`

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: Bump serde from 1.0.217 to 1.0.218 (#391) #914

Summary