Ben 2961 file rename 500 #143
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BEN-2961: ValidationError imported from rest framework
BEN-2961: increase version
mnadasan
reviewed
Apr 4, 2024
| @@ -9,7 +9,7 @@ | |||
| from django.contrib.auth import models as auth_models | |||
| from django.urls import reverse | |||
| from django.core.files.base import ContentFile | |||
| from django.core.exceptions import ValidationError | |||
| from rest_framework.exceptions import ValidationError | |||
There was a problem hiding this comment.
Can you add a description please to the PR? I don't understand the reason for this change. Normally this is a library that is not related and it should work without the rest framework.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.