Skip to content

Commit 07aa8ed

Browse files
shannonboothpbrw
authored andcommitted
LibURL: Set IDNA's IgnoreInvalidPunycode to false
See: whatwg/url@a6e449 - which should have no functional change.
1 parent 4fcb9da commit 07aa8ed

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

Libraries/LibURL/Parser.cpp

+4-2
Original file line numberDiff line numberDiff line change
@@ -506,7 +506,8 @@ static ErrorOr<String> domain_to_ascii(StringView domain, bool be_strict)
506506
// CheckJoiners set to true,
507507
// UseSTD3ASCIIRules set to beStrict,
508508
// Transitional_Processing set to false,
509-
// VerifyDnsLength set to beStrict. [UTS46].
509+
// VerifyDnsLength set to beStrict,
510+
// and IgnoreInvalidPunycode set to false. [UTS46]
510511

511512
// 2. If result is a failure value, domain-to-ASCII validation error, return failure.
512513

@@ -538,7 +539,8 @@ static ErrorOr<String> domain_to_ascii(StringView domain, bool be_strict)
538539
Unicode::IDNA::CheckJoiners::Yes,
539540
be_strict ? Unicode::IDNA::UseStd3AsciiRules::Yes : Unicode::IDNA::UseStd3AsciiRules::No,
540541
Unicode::IDNA::TransitionalProcessing::No,
541-
be_strict ? Unicode::IDNA::VerifyDnsLength::Yes : Unicode::IDNA::VerifyDnsLength::No
542+
be_strict ? Unicode::IDNA::VerifyDnsLength::Yes : Unicode::IDNA::VerifyDnsLength::No,
543+
Unicode::IDNA::IgnoreInvalidPunycode::No,
542544
};
543545
auto result = TRY(Unicode::IDNA::to_ascii(Utf8View(domain), options));
544546

0 commit comments

Comments
 (0)