Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Refactor] Forbidden DOM manipulation in state controller #50

Open
kofronpi opened this issue May 1, 2014 · 1 comment
Open

[Refactor] Forbidden DOM manipulation in state controller #50

kofronpi opened this issue May 1, 2014 · 1 comment
Assignees

Comments

@kofronpi
Copy link
Member

kofronpi commented May 1, 2014

In angularJS, no DOM manipulation should be done in controllers like this :

    $scope.state_bgcolor = "#f5f5f5";
    $scope.state_bordercolor = "#e3e3e3";

Explanations here http://ng-learn.org/2014/01/Dom-Manipulations/ and at many other places.
Instead one should use angular's directives : https://docs.angularjs.org/guide/directive

I'll do it soon

@mattgu74
Copy link
Member

mattgu74 commented May 1, 2014

Ok I assigned you to this issue ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants