This WILL break ECS during upgrades

[anarchy9388]

https://github.com/paychex/prometheus-emcecs-exporter/blob/master/pkg/ecsclient/ecsclient.go

// RetrieveNodeStateParallel pulls all the dtstate from nodes in the cluster all at once
func (c *EcsClient) RetrieveNodeStateParallel() []NodeState {
var NodeStates []NodeState
ch := make(chan NodeState)
for _, node := range c.nodeListMgmtIP {
go c.retrieveNodeState(node, ch)
}
for range c.nodeListMgmtIP {
NodeStates = append(NodeStates, <-ch)
}
return NodeStates
}

RetrieveNodeStateParallel needs to be removed it will cause massive outage during an upgrade

DTState only needs to be pulled from Rack1 node1 in the cluster.

Also please use this API so it uses cached results /stats/dt/DTAutoCheckResult

[shaunmp]

Hey,

Been looking at using this binary, but this issue makes me hesitate.

Are you able to elaborate on why this would cause an outage, and if this is still the case on more recent ECS versions?