Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
121948: cli: deflake TestLossOfQuorumRecovery r=arulajmani a=pav-kv

LOQ tooling works poorly when nodes stop in the middle of a split/merge operation. Prevent test flakes by making sure the scratch range split completes on all replicas, before turning down the nodes and running the LOQ tool. Also, disable the split and merge queue.

Fixes cockroachdb#121547
Epic: none
Release note: none

Co-authored-by: Pavel Kalinnikov <pavel@cockroachlabs.com>
  • Loading branch information
craig[bot] and pav-kv committed Apr 8, 2024
2 parents 3ba9c48 + 8adc1d0 commit 514d386
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions pkg/cli/debug_recover_loss_of_quorum_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -206,6 +206,9 @@ func TestLossOfQuorumRecovery(t *testing.T) {
// recovery, we'll check that the range is still accessible for writes as
// normal.
sk := tcBefore.ScratchRange(t)
// The LOQ tooling does not work when a node fails during a split/merge
// operation. Make sure that splitting the scratch range fully completes.
require.NoError(t, tcBefore.WaitForSplitAndInitialization(sk))
require.NoError(t,
tcBefore.Server(0).DB().Put(ctx, testutils.MakeKey(sk, []byte{1}), "value"),
"failed to write value to scratch range")
Expand Down

0 comments on commit 514d386

Please sign in to comment.