Add better tests for HFunctionFactoryTest

patrickfav · Nov 19, 2018 · eac6a3d · eac6a3d
1 parent 04fca5a
commit eac6a3d
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 0 deletions.
diff --git a/pom.xml b/pom.xml
@@ -182,6 +182,13 @@
             <version>4.12</version>
             <scope>test</scope>
         </dependency>
+        <!-- https://mvnrepository.com/artifact/org.bouncycastle/bcprov-jdk15on -->
+        <dependency>
+            <groupId>org.bouncycastle</groupId>
+            <artifactId>bcprov-jdk15on</artifactId>
+            <version>1.60</version>
+            <scope>test</scope>
+        </dependency>
     </dependencies>
 
     <developers>

diff --git a/src/test/java/at/favre/lib/crypto/HFunctionFactoryTest.java b/src/test/java/at/favre/lib/crypto/HFunctionFactoryTest.java
@@ -3,6 +3,8 @@
 import at.favre.lib.bytes.Bytes;
 import org.junit.Test;
 
+import java.security.Security;
+
 import static org.junit.Assert.*;
 
 public class HFunctionFactoryTest {
@@ -20,9 +22,11 @@ public void testIllegalHashFunctionHmac() {
     @Test
     public void testSimpleChecks() {
         simpleCheck(new HFunctionFactory.Default.DigestFactory("SHA-256"));
+        simpleCheck(new HFunctionFactory.Default.DigestFactory("SHA-256", Security.getProvider("BC")));
         simpleCheck(new HFunctionFactory.Default.DigestFactory("SHA-384"));
         simpleCheck(new HFunctionFactory.Default.DigestFactory("SHA-512"));
         simpleCheck(new HFunctionFactory.Default.MacFactory("HmacSha256"));
+        simpleCheck(new HFunctionFactory.Default.MacFactory("HmacSha256", Security.getProvider("BC")));
         simpleCheck(new HFunctionFactory.Default.MacFactory("HmacSha512"));
         simpleCheck(HFunctionFactory.Default.sha256());
         simpleCheck(HFunctionFactory.Default.sha512());