Delay Volume Updates (#19)

* Add check for comparing old volume with new volume * Add Copyright notice
parzival-space · Sep 8, 2024 · bdfafa4 · bdfafa4
1 parent de86bc4
commit bdfafa4
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 3 deletions.
diff --git a/FaderSyncPlugin/FaderSyncPlugin.csproj b/FaderSyncPlugin/FaderSyncPlugin.csproj
@@ -3,6 +3,7 @@
     <PropertyGroup>
         <!-- This Version will be used in CI -->
         <Version>1.2.1</Version>
+        <Copyright>© Malte Linke</Copyright>
     </PropertyGroup>
 
     <PropertyGroup>

diff --git a/FaderSyncPlugin/OBS/GoXlrChannelSyncFilter.cs b/FaderSyncPlugin/OBS/GoXlrChannelSyncFilter.cs
@@ -126,9 +126,16 @@ private static unsafe void Tick(void* data, float seconds)
                 break;
             }
 
-        // Update OBS Volume
-        Obs.obs_source_set_volume(target, obsVolume);
-        Obs.obs_source_set_muted(target, isMuted ? (byte)1 : (byte)0);
+        // only update channel if values changed
+        var oldMuteState = (byte)1 == Obs.obs_source_muted(target);
+        var oldVolume = Obs.obs_source_get_volume(target);
+        if (Math.Abs(oldVolume - obsVolume) > 0.0001 || isMuted != oldMuteState)
+        {
+            // Update OBS Volume
+            Obs.obs_source_set_volume(target, obsVolume);
+            Obs.obs_source_set_muted(target, isMuted ? (byte)1 : (byte)0);
+            Log.Info($"Updated volume for channel '{channelName}' to {obsVolume} (muted: {isMuted})");
+        }
     }
 
     [UnmanagedCallersOnly(CallConvs = new[] { typeof(CallConvCdecl) })]

diff --git a/UtilityClient/UtilityClient.csproj b/UtilityClient/UtilityClient.csproj
@@ -1,4 +1,8 @@
 <Project Sdk="Microsoft.NET.Sdk">
+
+    <PropertyGroup>
+        <Copyright>© Malte Linke</Copyright>
+    </PropertyGroup>
 
     <PropertyGroup>
         <TargetFramework>net8.0</TargetFramework>