-
-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add TypeScript support #9550
Conversation
Thanks for opening this pull request! |
722576b
to
c098c1b
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## alpha #9550 +/- ##
==========================================
- Coverage 93.50% 93.50% -0.01%
==========================================
Files 186 186
Lines 14809 14804 -5
==========================================
- Hits 13847 13842 -5
Misses 962 962 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! Could you please also convert a file (or parts of it?) to TS, as an example, to see whether the gradual conversion works?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe I have missed it; could you convert a simple file or a small part of a file to TS, just so we see that the gradual conversion works?
|
What would be needed to make the test:types job pass? I'm not sure but I believe in the JS SDK the test was passing even while the conversion was ongoing. |
Signed-off-by: Manuel <5673677+mtrezza@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Waiting for CI to pass...
# [8.0.0-alpha.9](8.0.0-alpha.8...8.0.0-alpha.9) (2025-01-30) ### Features * Add TypeScript support ([#9550](#9550)) ([59e46d0](59e46d0))
🎉 This change has been released in version 8.0.0-alpha.9 |
Pull Request
Issue
Closes: #7334
Approach
Note: The "options" and docs files that are generated are not currently compatible, as the babel plugin will need to be updated to support the new TS format.
Tasks