Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add TypeScript support #9550

Merged
merged 11 commits into from
Jan 30, 2025
Merged

Conversation

dblythy
Copy link
Member

@dblythy dblythy commented Jan 16, 2025

Pull Request

Issue

Closes: #7334

Approach

  • Typescript support for the Parse Server definitions.

Note: The "options" and docs files that are generated are not currently compatible, as the babel plugin will need to be updated to support the new TS format.

Tasks

  • Add tests
  • Add changes to documentation (guides, repository pages, code comments)
  • Add security check
  • Add new Parse Error codes to Parse JS SDK

Copy link

Thanks for opening this pull request!

Copy link

codecov bot commented Jan 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.50%. Comparing base (5966068) to head (5efa134).
Report is 3 commits behind head on alpha.

Additional details and impacted files
@@            Coverage Diff             @@
##            alpha    #9550      +/-   ##
==========================================
- Coverage   93.50%   93.50%   -0.01%     
==========================================
  Files         186      186              
  Lines       14809    14804       -5     
==========================================
- Hits        13847    13842       -5     
  Misses        962      962              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dblythy dblythy requested a review from a team January 21, 2025 11:46
mtrezza
mtrezza previously approved these changes Jan 21, 2025
Copy link
Member

@mtrezza mtrezza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Could you please also convert a file (or parts of it?) to TS, as an example, to see whether the gradual conversion works?

spec/.babelrc Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
@mtrezza mtrezza changed the title feat: begin typescript support feat: Add typescript support Jan 21, 2025
@mtrezza mtrezza changed the title feat: Add typescript support feat: Add TypeScript support Jan 21, 2025
Copy link
Member

@mtrezza mtrezza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe I have missed it; could you convert a simple file or a small part of a file to TS, just so we see that the gradual conversion works?

@dblythy
Copy link
Member Author

dblythy commented Jan 29, 2025

logger.ts is converted (all it needed was a file rename)

@mtrezza
Copy link
Member

mtrezza commented Jan 29, 2025

What would be needed to make the test:types job pass? I'm not sure but I believe in the JS SDK the test was passing even while the conversion was ongoing.

.github/workflows/ci.yml Outdated Show resolved Hide resolved
Signed-off-by: Manuel <5673677+mtrezza@users.noreply.github.com>
Copy link
Member

@mtrezza mtrezza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Waiting for CI to pass...

@mtrezza mtrezza merged commit 59e46d0 into parse-community:alpha Jan 30, 2025
23 of 24 checks passed
parseplatformorg pushed a commit that referenced this pull request Jan 30, 2025
# [8.0.0-alpha.9](8.0.0-alpha.8...8.0.0-alpha.9) (2025-01-30)

### Features

* Add TypeScript support ([#9550](#9550)) ([59e46d0](59e46d0))
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 8.0.0-alpha.9

@parseplatformorg parseplatformorg added the state:released-alpha Released as alpha version label Jan 30, 2025
@dblythy dblythy deleted the feat/typescript branch January 30, 2025 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
state:released-alpha Released as alpha version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve Typescript support
3 participants