-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
반경 내 주차장 조회 기능 구현 #13
Merged
Merged
Changes from 1 commit
Commits
Show all changes
44 commits
Select commit
Hold shift + click to select a range
f44658b
feat: jsonProperty 설정
youngh0 43ca5c9
feat: hibernate 공간 데이터 의존성 추가
youngh0 85f7423
feat: Location 의 필드를 공간데이터 타입 Point 로 수정
youngh0 7674fc9
feat: querydsl 의존성 추가
youngh0 c1fa2c3
feat: querydsl 의존성 제거
youngh0 ba3c449
feat: 주차장 목록 조회 쿼리 파라미터 전용 argument resolver 구현
youngh0 97ce588
feat: 반경 내 주차장 조회 쿼리 작성
youngh0 c4fad88
feat: argument resolver 등록
youngh0 0372e0d
feat: 반경 내 주차장 조회 controller, service(정렬, 필터링) 구현
youngh0 d399ab5
feat: builder 추가
youngh0 3469889
feat: 필터 기능하는 ParkingDomainService 추가
youngh0 7f49f6d
feat: 사용하지 않는 코드 제거
youngh0 6288499
feat: conflict 해결
youngh0 35a5747
Merge remote-tracking branch 'origin/main' into feat/10-find-parkingLots
youngh0 2d059a8
feat: 사용하지 않는 repository 삭제
youngh0 592b1c7
feat: 요금 계산 bean 추가
youngh0 f8b4dbd
feat: 주차장 목록 조회 시 사용자 조회 조건 필터링 구현
youngh0 d33ee40
feat: 메서드 분리
youngh0 44ae717
feat: 주차장 도보 예상 시간 로직 테스트 작성
youngh0 28ce548
refactor: 주석 제거
youngh0 6b7459f
feat: 주차장 목록 조회 시 조회 조건 엔티티로 대체 가능한 query param 제거
youngh0 d5ca66d
feat: 주차장 검색 조건 request 생성
youngh0 4c780fc
feat: 검색 조건 변환 기능 구현
youngh0 5f608cc
feat: 반경조회 비회원 조회 구현
youngh0 d008f2e
feat: memberId 아규먼트 리졸버 구현
youngh0 0035310
feat: feeType 타입 변경
youngh0 227cf26
feat: enum 의 value list 변환 로직 SearchConditionAvailable 로 이동
youngh0 a4dc6a1
feat: String 과 일치하는 enum List 변환 로직 SearchConditionAvailable 로 이동
youngh0 84b1100
feat: find 메서드 구현
youngh0 2973615
feat: 무료인지 확인하는 메서드 구현
youngh0 9d03477
feat: 검색조건 유.무료에 맞는 필터링 기능 구현
youngh0 1f31077
refactor: ParkingDomainService -> ParkingApplicationService 네이밍 변경
youngh0 6c04212
test: 유.무료 필터링 테스트
youngh0 b35c425
refactor: 네이밍 수정
youngh0 f1fa25b
feat: 비회원 기능 회원 인증 시 sessionId null 반환하도록 수정
youngh0 3b9d046
feat: 불필요한 메서드 제거
youngh0 9d5693e
Merge remote-tracking branch 'origin/main' into feat/10-find-parkingLots
youngh0 dfac844
feat: 충돌 해결
youngh0 4528710
feat: swagger 추가
youngh0 5362f5d
refactor: 서비스 계층에서 String <-> SearchConditionAvailable Enum 변환 로직 개선
This2sho 03dcdd3
fix: 잘못 사용되고 있는 값 객체 제거
This2sho fc15e7e
feat: 응답 dto 변환 로직 이동
youngh0 7b48ca1
refactor: 네이밍 수정
youngh0 4fe6e61
feat: 현재 시간 변수 생성 위치 수정
youngh0 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 changes: 11 additions & 0 deletions
11
src/main/java/com/example/parking/config/argumentresolver/parking/ParkingMemberId.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
package com.example.parking.config.argumentresolver.parking; | ||
|
||
import java.lang.annotation.ElementType; | ||
import java.lang.annotation.Retention; | ||
import java.lang.annotation.RetentionPolicy; | ||
import java.lang.annotation.Target; | ||
|
||
@Target(ElementType.PARAMETER) | ||
@Retention(RetentionPolicy.RUNTIME) | ||
public @interface ParkingMemberId { | ||
} |
22 changes: 22 additions & 0 deletions
22
.../com/example/parking/config/argumentresolver/parking/ParkingMemberIdArgumentResolver.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,22 @@ | ||
package com.example.parking.config.argumentresolver.parking; | ||
|
||
import org.springframework.core.MethodParameter; | ||
import org.springframework.stereotype.Component; | ||
import org.springframework.web.bind.support.WebDataBinderFactory; | ||
import org.springframework.web.context.request.NativeWebRequest; | ||
import org.springframework.web.method.support.HandlerMethodArgumentResolver; | ||
import org.springframework.web.method.support.ModelAndViewContainer; | ||
|
||
@Component | ||
public class ParkingMemberIdArgumentResolver implements HandlerMethodArgumentResolver { | ||
@Override | ||
public boolean supportsParameter(MethodParameter parameter) { | ||
return parameter.hasParameterAnnotation(ParkingMemberId.class); | ||
} | ||
|
||
@Override | ||
public Long resolveArgument(MethodParameter parameter, ModelAndViewContainer mavContainer, | ||
NativeWebRequest webRequest, WebDataBinderFactory binderFactory) throws Exception { | ||
return Long.parseLong(webRequest.getParameter("JSESSIONID")); | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
MemberAuth
랑 역할이 동일한거 같은데무슨 차이인가여?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
기존의 MemberAuth 는 잘못된 인증 정보면 예외를 던지는데 주차장 조회 기능에선 memberId 가 없으면 즐겨찾기 값을 전부 다 false 로 반환해야됩니다.
그래서 기존 MemberAuth의 잘못된 인증정보 시 예외던지는 코드를 주차장 조회 기능 때문에 null 을 반환하게 하면 MemberAuth 를 사용하고 있는 다른 로직에서 반환된 값의 null 체크를 하고 예외처리를 해야되기 때문에 예외 말고 null 을 반환하도록 새로 만들었습니다.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
같은 목적의 어노테이션을 두개로 늘리기 보다는
아래처럼 필드를 추가해주고
아규먼트 리졸버에서 required 값을 판단해서 아래처럼 내려주면 될 거 같습니다
그러고 회원 정보가 필수가 아닌 컨트롤러에서 적용해주면 될 거 같습니다
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
오 이건 생각 못했는데 아이디어 감사합니다 ㅎ