Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove needlessness async block and await op #14694

Merged
merged 1 commit into from
Feb 25, 2025
Merged

remove needlessness async block and await op #14694

merged 1 commit into from
Feb 25, 2025
+1 −1

Conversation

Pana
Copy link
Contributor

@Pana Pana commented Feb 25, 2025 •
edited
Loading

Seems the inside async block is useless, and can be removed, and this also should not lead to performance issue

@Pana Pana requested review from mattsse and Rjected as code owners February 25, 2025 05:26
mattsse
mattsse approved these changes Feb 25, 2025
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep, I'm pretty sure this is due to some older,incorrect clippy lint iirc

@mattsse mattsse added this pull request to the merge queue Feb 25, 2025
Merged via the queue into paradigmxyz:main with commit 84ef51f Feb 25, 2025
43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

Assignees
No one assigned
Labels
None yet
Projects
Reth Tracker
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Pana @mattsse