feat(net): ress subprotocol
#14687
Open
feat(net): ress subprotocol
#14687
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rkrasiuk
added
C-enhancement
mattsse
requested changes
Feb 25, 2025
Comment on lines
+22
to
+35
| /// Get block headers. | ||
| GetHeaders { | ||
| /// The request for block headers. | ||
| request: GetHeaders, | ||
| /// The sender for the response. | ||
| tx: oneshot::Sender<Vec<Header>>, | ||
| }, | ||
| /// Get block bodies. | ||
| GetBlockBodies { | ||
| /// The request for block bodies. | ||
| request: Vec<BlockHash>, | ||
| /// The sender for the response. | ||
| tx: oneshot::Sender<Vec<BlockBody>>, | ||
| }, |
There was a problem hiding this comment.
do we need those, because those are already part of the eth proto and we could reuse those instead?
| } | ||
|
|
||
| loop { | ||
| if let Poll::Ready(Some(cmd)) = this.commands.poll_next_unpin(cx) { |
There was a problem hiding this comment.
this can poll a finished stream, if the exist logic is independent from that you can fuse this receiver
| } | ||
| }; | ||
|
|
||
| match msg.message { |
There was a problem hiding this comment.
can we move this to a function?
| _direction: Direction, | ||
| _peer_id: PeerId, | ||
| ) -> OnNotSupported { | ||
| OnNotSupported::Disconnect |
There was a problem hiding this comment.
this should probably check the nodetype, because we dont want to disconnect if the node is stateful but the other peer doesnt support it?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds
reth-network-resscrate which definesressRLPx subprotocol for stateless nodes.