refactor: implement BlockExecutionStrategyFactory directly on EvmConfig
#14675
+253
−436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattsse
approved these changes
Feb 24, 2025
Comment on lines
-250
to
-253
| let chain_spec = ctx.chain_spec(); | ||
| let evm_config = EthEvmConfig::new(ctx.chain_spec()); | ||
| let strategy_factory = EthExecutionStrategyFactory::new(chain_spec, evm_config.clone()); | ||
| let executor = BasicBlockExecutorProvider::new(strategy_factory); |
| @@ -191,7 +191,7 @@ pub trait BlockExecutionStrategy { | |||
| } | |||
|
|
|||
| /// A strategy factory that can create block execution strategies. | |||
| pub trait BlockExecutionStrategyFactory: Send + Sync + Clone + Unpin + 'static { | |||
| pub trait BlockExecutionStrategyFactory: ConfigureEvmFor<Self::Primitives> { | |||
mattsse
added
M-changelog
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #14571
Exposes
BlockExecutionStrategyFactoryimplementation directly onEvmConfigthus fully encapsulating block and transaction execution semantics in it.This allows all of the components holding
EvmConfigto get access to pre/post execution changes and receipts construction implementation without additional generics