User receipt Serdebincodecompat for chain type serde #14669
+89
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattsse
reviewed
Feb 24, 2025
Comment on lines
646
to
651
| ExecutionOutcome { | ||
| bundle: original.bundle.clone(), | ||
| receipts: converted_receipts, | ||
| requests: original.requests.clone(), | ||
| first_block: original.first_block, | ||
| } |
There was a problem hiding this comment.
these clones are a bit expensive,
perhaps the better approach long term is to alos introduce a dedicated bincode compat type for ExecutionOutCome?
then we can also mostly leave this untouched and can use that type for the Chain type?
There was a problem hiding this comment.
yeah that seems more accurate !!
i'll change it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #14626