Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move account types to db-models crate #14653

Open
mattsse opened this issue Feb 22, 2025 · 2 comments
Open

Move account types to db-models crate #14653

mattsse opened this issue Feb 22, 2025 · 2 comments
Assignees
@frankudoags
Labels
A-db Related to the database C-enhancement New feature or request

Comments

@mattsse
Copy link
Collaborator

mattsse commented Feb 22, 2025 •
edited
Loading

Describe the feature

these types don't really belong into the db-api crate

reth/crates/storage/db-api/src/models/accounts.rs

Line 19 in ea68078

pub struct BlockNumberAddress(pub (BlockNumber, Address));

reth/crates/storage/db-api/src/models/accounts.rs

Line 80 in ea68078

pub struct AddressStorageKey(pub (Address, StorageKey));

there are more but we can start with these types

TODO

  • move struct defs to db-models
  • keep trait impls in db-api

cc @frankudoags

Additional context

#14647
@mattsse mattsse added C-enhancement New feature or request S-needs-triage This issue needs to be labelled labels Feb 22, 2025
@mattsse mattsse added A-db Related to the database and removed S-needs-triage This issue needs to be labelled labels Feb 22, 2025
@frankudoags
Copy link
Contributor

Will work on this. 🙏🏾

@mattsse
Copy link
Collaborator Author

mattsse commented Feb 22, 2025

ty 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@frankudoags frankudoags

Labels
A-db Related to the database C-enhancement New feature or request
Projects
Reth Tracker
Status: Todo
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mattsse @frankudoags