feat(storage): log revert state outcome in consistent view

paradigmxyz · Feb 24, 2025 · 83ced4b · 83ced4b
1 parent 340d7ba
commit 83ced4b
Showing 1 changed file with 14 additions and 3 deletions.
diff --git a/crates/storage/provider/src/providers/consistent_view.rs b/crates/storage/provider/src/providers/consistent_view.rs
@@ -8,6 +8,7 @@ use reth_trie::HashedPostState;
 use reth_trie_db::{DatabaseHashedPostState, StateCommitment};
 
 pub use reth_storage_errors::provider::ConsistentViewError;
+use tracing::debug;
 
 /// A consistent view over state in the database.
 ///
@@ -54,11 +55,21 @@ where
         let block_number = provider
             .block_number(block_hash)?
             .ok_or(ProviderError::BlockHashNotFound(block_hash))?;
-        if block_number == provider.best_block_number()? &&
-            block_number == provider.last_block_number()?
-        {
+        let best_block_number = provider.best_block_number()?;
+        let last_block_number = provider.last_block_number()?;
+
+        if block_number == best_block_number && block_number == last_block_number {
+            debug!(target: "providers::consistent_view", ?block_hash, block_number, "Returning empty revert state");
             Ok(HashedPostState::default())
         } else {
+            debug!(
+                target: "providers::consistent_view",
+                ?block_hash,
+                block_number,
+                best_block_number,
+                last_block_number,
+                "Returning non-empty revert state"
+            );
             Ok(HashedPostState::from_reverts::<
                 <Factory::StateCommitment as StateCommitment>::KeyHasher,
             >(provider.tx_ref(), block_number + 1)?)