add the privacy plugin #19
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is this waiting for review? |
|
@albertov19 yes! sorry I thought I requested a review on it but I didn't haha ooops 😬 |
albertov19
approved these changes
Feb 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the privacy plugin to the docs site; what this does is download all external assets and self-host them. The external assets that are downloaded can be scripts, style sheets, JSON files, images, and web fonts.
At this point in time, it benefits us by downloading and caching fonts. It can also provide additional benefits down the road if we add any more external assets.
Generally speaking, this can improve load performance.
As a side note, it's called the privacy plugin because it was designed to comply with the 2018 European General Data Protection Regulation (GDPR). More information can be found here: https://squidfunk.github.io/mkdocs-material/plugins/privacy/