BUG: fix PeriodIndex.difference producing incorrect results #60992
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -534,6 +534,22 @@ def shift(self, periods: int = 1, freq=None) -> Self: | |||
| ) | |||
| return self + periods | |||
|
|
|||
| def _convert_can_do_setop(self, other): | |||
| try: | |||
| if isinstance(other, Index): | |||
There was a problem hiding this comment.
A lot of this can be outside a try/except
There was a problem hiding this comment.
@jbrockmendel Thank you for the review, but before submitting the revision, I would like to confirm with you whether you think this modification direction is correct.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Index.differenceis returning too many values #58971doc/source/whatsnew/v3.0.0.rstfile if fixing a bug or adding a new feature.