Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: fix error message for multiindex.fillna #60974

Merged
merged 1 commit into from
Feb 20, 2025

Conversation

MarcoGorelli
Copy link
Member

@MarcoGorelli MarcoGorelli commented Feb 20, 2025

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

It's very surprising to me that there's 3 different tests which explicitly check this error message, yet the discrepancy was never noticed (unless I'm missing something here, which is definitely a possibility)

@MarcoGorelli MarcoGorelli marked this pull request as ready for review February 20, 2025 15:37
@mroeschke mroeschke added Error Reporting Incorrect or improved errors from pandas MultiIndex labels Feb 20, 2025
@mroeschke mroeschke added this to the 3.0 milestone Feb 20, 2025
@mroeschke mroeschke merged commit 1d8bbb7 into pandas-dev:main Feb 20, 2025
47 checks passed
@mroeschke
Copy link
Member

Thanks @MarcoGorelli

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Error Reporting Incorrect or improved errors from pandas MultiIndex
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants