ENH(string dtype): Implement cumsum for Python-backed strings #60938
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pandas/core/arrays/string_.py
Outdated
| # We can retain the running min/max by forward/backward filling. | ||
| ndarray = ndarray.copy() | ||
| missing.pad_or_backfill_inplace( | ||
| ndarray.T, |
There was a problem hiding this comment.
Is the .T needed? (I would think that ndarray is 1D)
pandas/core/arrays/string_.py
Outdated
| # the first NA value onward. | ||
| idx = np.argmax(na_mask) | ||
| tail = np.empty(len(ndarray) - idx, dtype="object") | ||
| tail[:] = np.nan |
There was a problem hiding this comment.
Suggested change
| tail[:] = np.nan | |
| tail[:] = self.dtype.na_value |
So we directly fill it with the appropriate NA value (although I assume the constructor would fix it up anyway)
pandas/core/arrays/string_.py
Outdated
| if tail is not None: | ||
| np_result = np.hstack((np_result, tail)) | ||
| elif na_mask is not None: | ||
| np_result = np.where(na_mask, np.nan, np_result) |
There was a problem hiding this comment.
Suggested change
| np_result = np.where(na_mask, np.nan, np_result) | |
| np_result = np.where(na_mask, self.dtype.na_value, np_result) |
WillAyd
approved these changes
Feb 18, 2025
mroeschke
approved these changes
Feb 19, 2025
|
Thanks @rhshadrach |
|
Owee, I'm MrMeeseeks, Look at me. There seem to be a conflict, please backport manually. Here are approximate instructions:
And apply the correct labels and milestones. Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon! Remember to remove the If these instructions are inaccurate, feel free to suggest an improvement. |
rhshadrach
added a commit
to rhshadrach/pandas
that referenced
this pull request
Feb 22, 2025
… Python-backed strings
|
Backport PR: #60984 |
mroeschke
pushed a commit
that referenced
this pull request
Feb 22, 2025
…cked strings (#60984) * ENH: Improved error message and raise new error for small-string NaN edge case in HDFStore.append (#60829) * Add clearer error messages for datatype mismatch in HDFStore.append. Raise ValueError when nan_rep too large for pytable column. Add and modify applicable test code. * Fix missed tests and correct mistake in error message. * Remove excess comments. Reverse error type change to avoid api changes. Move nan_rep tests into separate function. (cherry picked from commit 57340ec) * TST(string dtype): Resolve xfails in pytables (#60795) (cherry picked from commit 4511251) * BUG(string dtype): Resolve pytables xfail when reading with condition (#60943) (cherry picked from commit 0ec5f26) * Backport PR #60940: ENH: Add dtype argument to str.decode * Backport PR #60938: ENH(string dtype): Implement cumsum for Python-backed strings --------- Co-authored-by: Jake Thomas Trevallion <136272202+JakeTT404@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up on #60633