Skip to content

Commit

Permalink
CI: unxfail adbc-driver-postgresql test (#56873)
Browse files Browse the repository at this point in the history
* unxfail adbc-driver-postgresql test

* conditional xfail

* catch None

* adbc_driver_manager -> adbc_driver_postgresql
  • Loading branch information
MarcoGorelli authored Jan 14, 2024
1 parent 0147ced commit 73bc5f4
Showing 1 changed file with 7 additions and 5 deletions.
12 changes: 7 additions & 5 deletions pandas/tests/io/test_sql.py
Original file line number Diff line number Diff line change
Expand Up @@ -2229,12 +2229,14 @@ def test_api_chunksize_read(conn, request):
@pytest.mark.parametrize("conn", all_connectable)
def test_api_categorical(conn, request):
if conn == "postgresql_adbc_conn":
request.node.add_marker(
pytest.mark.xfail(
reason="categorical dtype not implemented for ADBC postgres driver",
strict=True,
adbc = import_optional_dependency("adbc_driver_postgresql", errors="ignore")
if adbc is not None and Version(adbc.__version__) < Version("0.9.0"):
request.node.add_marker(
pytest.mark.xfail(
reason="categorical dtype not implemented for ADBC postgres driver",
strict=True,
)
)
)
# GH8624
# test that categorical gets written correctly as dense column
conn = request.getfixturevalue(conn)
Expand Down

0 comments on commit 73bc5f4

Please sign in to comment.