Skip to content

Commit

Permalink
Backport PR #60929 on branch 2.3.x (TST: Update numpy version check f…
Browse files Browse the repository at this point in the history
…or test_pandas_dtype_numpy_warning) (#60930)

Backport PR #60929: TST: Update numpy version check for test_pandas_dtype_numpy_warning

Co-authored-by: Matthew Roeschke <10647082+mroeschke@users.noreply.github.com>
  • Loading branch information
meeseeksmachine and mroeschke authored Feb 14, 2025
1 parent 79e203e commit 12cd45e
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion pandas/core/dtypes/common.py
Original file line number Diff line number Diff line change
Expand Up @@ -1654,7 +1654,7 @@ def pandas_dtype(dtype) -> DtypeObj:
# raise a consistent TypeError if failed
try:
with warnings.catch_warnings():
# TODO: warnings.catch_warnings can be removed when numpy>2.2.2
# TODO: warnings.catch_warnings can be removed when numpy>2.3.0
# is the minimum version
# GH#51523 - Series.astype(np.integer) doesn't show
# numpy deprecation warning of np.integer
Expand Down
2 changes: 1 addition & 1 deletion pandas/tests/dtypes/test_common.py
Original file line number Diff line number Diff line change
Expand Up @@ -789,7 +789,7 @@ def test_validate_allhashable():

def test_pandas_dtype_numpy_warning():
# GH#51523
if Version(np.__version__) <= Version("2.2.2"):
if Version(np.__version__) < Version("2.3.0.dev0"):
ctx = tm.assert_produces_warning(
DeprecationWarning,
check_stacklevel=False,
Expand Down

0 comments on commit 12cd45e

Please sign in to comment.