Fix Linux build issues #15
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Was giving a `output file specified twice` error because the Makefile referenced `-openmp` instead of `-fopenmp`
palucdev
requested changes
Nov 28, 2022
| @@ -20,7 +21,7 @@ list_sources: | |||
|
|
|||
| build: | |||
| mkdir -p ${BUILD_DIR} | |||
| nvcc -x cu ${SOURCE_FILES} --std=c++11 -lineinfo -o ${BUILD_DIR}/${EXEC_FILE} -Xcompiler -openmp | |||
| nvcc -x cu ${SOURCE_FILES} --std=c++11 -lineinfo -o ${BUILD_DIR}/${EXEC_FILE} -Xcompiler -fopenmp | |||
There was a problem hiding this comment.
-fopenmp flag is throwing alot of warnings when building on Windows. Looks like compiler differences. -fopenmp is connected with gcc, windows nvcc command supports only cl.exe. It will be good to differentiate this flag based upon OS (like in SOURCE_FILE initialization).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I couldn't get the project to compile on my Ubuntu 22.04 machine, so I made a few changes. I don't currently have a Windows system handy to test all this on, so let me know if I broke anything. I could try to fix it next week when I have access to the lab machines again