Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix duplicate HTML ids in templates. #1062

Merged
merged 1 commit into from
Jan 22, 2025
Merged

Fix duplicate HTML ids in templates. #1062

merged 1 commit into from
Jan 22, 2025

Conversation

jwag956
Copy link
Collaborator

@jwag956 jwag956 commented Jan 22, 2025

This was introduced when adding

containers around most fields.

@ademaro

This was introduced when adding <div> containers around most fields.
Copy link

codecov bot commented Jan 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.43%. Comparing base (20d7bf4) to head (4cd02d6).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1062   +/-   ##
=======================================
  Coverage   98.43%   98.43%           
=======================================
  Files          39       39           
  Lines        4917     4917           
=======================================
  Hits         4840     4840           
  Misses         77       77           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jwag956 jwag956 merged commit 0047342 into main Jan 22, 2025
21 checks passed
@jwag956 jwag956 deleted the divid branch January 22, 2025 18:29
@ademaro
Copy link
Contributor

ademaro commented Jan 23, 2025

Thanks, it looks great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants