Fix prefer-const for TypeScript <2.1 (#1989)

palantir · Jan 5, 2017 · 23552e0 · 23552e0
1 parent b20dfce
commit 23552e0
Showing 1 changed file with 9 additions and 1 deletion.
diff --git a/src/rules/preferConstRule.ts b/src/rules/preferConstRule.ts
@@ -55,7 +55,15 @@ class PreferConstWalker extends Lint.BlockScopeAwareRuleWalker<{}, ScopeInfo> {
     }
 
     private static collectInVariableDeclarationList(node: ts.VariableDeclarationList, scopeInfo: ScopeInfo) {
-        if (isCombinedNodeFlagSet(node, ts.NodeFlags.Let) && !isCombinedModifierFlagSet(node, ts.ModifierFlags.Export)) {
+        let allowConst: boolean;
+        if ((ts as any).getCombinedModifierFlags === undefined) {
+            // for back-compat, TypeScript < 2.1
+            allowConst = isCombinedNodeFlagSet(node, ts.NodeFlags.Let)
+                && !Lint.hasModifier(node.parent!.modifiers, ts.SyntaxKind.ExportKeyword);
+        } else {
+            allowConst = isCombinedNodeFlagSet(node, ts.NodeFlags.Let) && !isCombinedModifierFlagSet(node, ts.ModifierFlags.Export);
+        }
+        if (allowConst) {
             for (const decl of node.declarations) {
                 PreferConstWalker.addDeclarationName(decl.name, node, scopeInfo);
             }