Remove redundant cast

Author: wendigo

core/trino-main/src/main/java/io/trino/json/PathEvaluationVisitor.java

@@ -723,7 +723,7 @@ private static TypedValue getDouble(TypedValue typedValue)
         if (type instanceof DecimalType decimalType) {
             int precision = decimalType.getPrecision();
             int scale = decimalType.getScale();
-            if (((DecimalType) type).isShort()) {
+            if (decimalType.isShort()) {
                 long tenToScale = longTenToNth(DecimalConversions.intScale(scale));
                 return new TypedValue(DOUBLE, shortDecimalToDouble(typedValue.getLongValue(), precision, scale, tenToScale));
             }
@@ -852,7 +852,7 @@ protected List<Object> visitIrKeyValueMethod(IrKeyValueMethod node, PathEvaluati
 
             // non-unique keys are not supported. if they were, we should follow the spec here on handling them.
             // see the comment in `visitIrMemberAccessor` method.
-            ((JsonNode) object).fields().forEachRemaining(
+            jsonNode.fields().forEachRemaining(
                     field -> outputSequence.add(new ObjectNode(
                             JsonNodeFactory.instance,
                             ImmutableMap.of(

core/trino-main/src/main/java/io/trino/sql/planner/DomainTranslator.java

@@ -1073,7 +1073,7 @@ private Optional<ExtractionResult> tryVisitStartsWithFunction(Call node, Boolean
             }
 
             Symbol symbol = Symbol.from(target);
-            Slice constantPrefix = (Slice) ((Constant) prefix).value();
+            Slice constantPrefix = (Slice) literal.value();
 
             return createRangeDomain(type, constantPrefix).map(domain -> new ExtractionResult(TupleDomain.withColumnDomains(ImmutableMap.of(symbol, domain)), node));
         }

core/trino-main/src/main/java/io/trino/sql/planner/TranslationMap.java

@@ -849,7 +849,7 @@ private io.trino.sql.ir.Expression translate(AtTimeZone node)
         if (valueType instanceof TimeType type) {
             call = BuiltinFunctionCallBuilder.resolve(plannerContext.getMetadata())
                     .setName("$at_timezone")
-                    .addArgument(createTimeWithTimeZoneType(type.getPrecision()), new io.trino.sql.ir.Cast(value, createTimeWithTimeZoneType(((TimeType) valueType).getPrecision())))
+                    .addArgument(createTimeWithTimeZoneType(type.getPrecision()), new io.trino.sql.ir.Cast(value, createTimeWithTimeZoneType(type.getPrecision())))
                     .addArgument(timeZoneType, timeZone)
                     .build();
         }
@@ -863,7 +863,7 @@ else if (valueType instanceof TimeWithTimeZoneType) {
         else if (valueType instanceof TimestampType type) {
             call = BuiltinFunctionCallBuilder.resolve(plannerContext.getMetadata())
                     .setName("at_timezone")
-                    .addArgument(createTimestampWithTimeZoneType(type.getPrecision()), new io.trino.sql.ir.Cast(value, createTimestampWithTimeZoneType(((TimestampType) valueType).getPrecision())))
+                    .addArgument(createTimestampWithTimeZoneType(type.getPrecision()), new io.trino.sql.ir.Cast(value, createTimestampWithTimeZoneType(type.getPrecision())))
                     .addArgument(timeZoneType, timeZone)
                     .build();
         }

core/trino-main/src/main/java/io/trino/sql/planner/optimizations/PlanNodeDecorrelator.java

@@ -542,7 +542,7 @@ private boolean isSimpleInjectiveCast(Expression expression)
             Symbol sourceSymbol = Symbol.from(cast.expression());
 
             Type sourceType = sourceSymbol.type();
-            Type targetType = ((Cast) expression).type();
+            Type targetType = cast.type();
 
             return typeCoercion.isInjectiveCoercion(sourceType, targetType);
         }

core/trino-parser/src/main/java/io/trino/sql/SqlFormatter.java

@@ -527,8 +527,7 @@ protected Void visitTableArgument(TableFunctionTableArgument node, Integer inden
             builder.append("TABLE(");
             process(unaliased, indent);
             builder.append(")");
-            if (relation instanceof AliasedRelation) {
-                AliasedRelation aliasedRelation = (AliasedRelation) relation;
+            if (relation instanceof AliasedRelation aliasedRelation) {
                 builder.append(" AS ")
                         .append(formatName(aliasedRelation.getAlias()));
                 appendAliasColumns(builder, aliasedRelation.getColumnNames());
@@ -851,14 +850,12 @@ protected Void visitJoin(Join node, Integer indent)
             process(node.getRight(), indent);
 
             if (node.getType() != Join.Type.CROSS && node.getType() != Join.Type.IMPLICIT) {
-                if (criteria instanceof JoinUsing) {
-                    JoinUsing using = (JoinUsing) criteria;
+                if (criteria instanceof JoinUsing using) {
                     builder.append(" USING (")
                             .append(Joiner.on(", ").join(using.getColumns()))
                             .append(")");
                 }
-                else if (criteria instanceof JoinOn) {
-                    JoinOn on = (JoinOn) criteria;
+                else if (criteria instanceof JoinOn on) {
                     builder.append(" ON ")
                             .append(formatExpression(on.getExpression()));
                 }
@@ -1596,12 +1593,10 @@ protected Void visitCreateTable(CreateTable node, Integer indent)
             String elementIndent = indentString(indent + 1);
             String columnList = node.getElements().stream()
                     .map(element -> {
-                        if (element instanceof ColumnDefinition) {
-                            ColumnDefinition column = (ColumnDefinition) element;
+                        if (element instanceof ColumnDefinition column) {
                             return elementIndent + formatColumnDefinition(column);
                         }
-                        if (element instanceof LikeClause) {
-                            LikeClause likeClause = (LikeClause) element;
+                        if (element instanceof LikeClause likeClause) {
                             StringBuilder builder = new StringBuilder(elementIndent);
                             builder.append("LIKE ")
                                     .append(formatName(likeClause.getTableName()));

core/trino-parser/src/main/java/io/trino/sql/tree/ExpressionTreeRewriter.java

@@ -544,8 +544,7 @@ private List<SortItem> rewriteSortItems(List<SortItem> sortItems, Context<C> con
 
         private Window rewriteWindow(Window window, Context<C> context)
         {
-            if (window instanceof WindowReference) {
-                WindowReference windowReference = (WindowReference) window;
+            if (window instanceof WindowReference windowReference) {
                 Identifier rewrittenName = rewrite(windowReference.getName(), context.get());
                 if (windowReference.getName() != rewrittenName) {
                     return new WindowReference(rewrittenName);
@@ -986,8 +985,7 @@ protected Expression visitGenericDataType(GenericDataType node, Context<C> conte
                 if (argument instanceof NumericParameter) {
                     arguments.add(argument);
                 }
-                else if (argument instanceof TypeParameter) {
-                    TypeParameter parameter = (TypeParameter) argument;
+                else if (argument instanceof TypeParameter parameter) {
                     DataType value = (DataType) process(parameter.getValue(), context);
 
                     if (value != parameter.getValue()) {

plugin/trino-hive/src/test/java/io/trino/plugin/hive/TestHiveFileFormats.java

@@ -1427,7 +1427,7 @@ else if (type instanceof CharType charType) {
             if (object instanceof HiveChar) {
                 object = ((HiveChar) object).getValue();
             }
-            charType.writeSlice(builder, truncateToLengthAndTrimSpaces(utf8Slice((String) object), ((CharType) type).getLength()));
+            charType.writeSlice(builder, truncateToLengthAndTrimSpaces(utf8Slice((String) object), charType.getLength()));
         }
         else if (type == DATE) {
             long days = ((Date) object).toEpochDay();

plugin/trino-tpch/src/test/java/io/trino/plugin/tpch/EstimateAssertion.java

@@ -63,7 +63,7 @@ private void assertClose(Object actual, Object expected, String comparedValue)
             assertThat(actual.getClass())
                     .describedAs(comparedValue)
                     .isEqualTo(expected.getClass());
-            assertThat(((Slice) actual).toStringUtf8())
+            assertThat(actualSlice.toStringUtf8())
                     .isEqualTo(((Slice) expected).toStringUtf8());
         }
         else if (actual instanceof DoubleRange actualRange) {